Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use peerDependencies #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use peerDependencies #37

wants to merge 2 commits into from

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Jan 11, 2024

This PR moves (back) to peer dependencies instead of relying on dependencies. According to the previous PR this move away from peerDeps was related to toolkit...

Use dependencies for now
... so that it's not installed to a plugin's node_modules/@grafana/toolkit/node_modules dir but to the parent one where eslint can find it. We can reverse this when we migrate from yarn back to npm (v7+) which installs peerDependencies.

Toolkit is no more and keeping these in sync for grafana/grafana and plugins is a bit of a chore. Peer dependencies should make our lives easier. Seems quite common to use peerDeps for configs:

@jackw jackw added the dependencies Pull requests that update a dependency file label Jan 11, 2024
@jackw jackw self-assigned this Jan 11, 2024
Copy link

@abannachGrafana abannachGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will also match us back up to the README suggesting running npx install-peerdeps --dev @grafana/eslint-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants