fix(GitHub Integration): Correctly extract the start/end timestamps from time picker #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame graph container For reasons I don't understand, doing this trick to switch the flame graph container mode results in the component continuously rerendering. Aside from obvious performance problems, this component with also trigger network calls when rerendering, resulting in its contents becoming basically useless.
…lues from the url
Unit test coverage
|
grafakus
reviewed
Jul 2, 2024
src/pages/ProfilesExplorerView/exploration-types/SceneServiceFlameGraph/SceneFlameGraph.tsx
Outdated
Show resolved
Hide resolved
grafakus
reviewed
Jul 2, 2024
src/shared/components/FunctionDetailsPanel/infrastructure/useFetchFunctionsDetails.ts
Outdated
Show resolved
Hide resolved
…lues from the url
…iles into gh-explore-profiles
bryanhuhta
changed the title
grafakus
reviewed
Jul 10, 2024
| timelineAndProfileApiClient.setLastTimeRange(globalTimeRangeState.state.value); | ||
| } | ||
|
|
||
| const timeRangeSubscription = globalTimeRangeState?.subscribeToState((newState) => { |
There was a problem hiding this comment.
I'm afraid this will not work as expected. E.g. switching from cpu to goroutine will not update the timerange.
The correct solution is to listen to data loading changes:
const data = buildTimeSeriesQueryRunner({});
...
data.subscribeToState((newState) => {
if (newState.data.state === LoadingState.Loading) {
/// capture time range
}
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Since #5, we stopped collecting the
startandendvalues from the url state correctly. This meant we passed emptystartandendvalues to the backend when callingSelectMergeProfileto get a profile for a time range and stack trace. In turn, the backend would pass back an empty response because the time range (0 to 0) didn't match any blocks.📖 Summary of the changes
This PR fixes how the UI sets the
startandendwhen makingSelectMergeProfilerequests. It also fixes a rendering but where the flame graph scene would continuously re-render. It also correctly setskeepCookiesin the sample provisioned data sources.🧪 How to test?
Run locally