Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to exclude requests to certain urls from tracking on a global level #553

Closed
codecapitano opened this issue Apr 10, 2024 · 3 comments · Fixed by #554
Closed

Allow to exclude requests to certain urls from tracking on a global level #553

codecapitano opened this issue Apr 10, 2024 · 3 comments · Fixed by #554
Assignees
Labels
feature Request a new feature

Comments

@codecapitano
Copy link
Collaborator

codecapitano commented Apr 10, 2024

Why

Currently Faro tracks all requests (and resources) besides call to the collector itself.
This can lead to signals being emitted which are not very interesting.
For example users may not be interested in the request performance / resource timings of requests to analytics libraries or other 3rd parties.

What

  • Allow a central configuration to exclude calls to certain urls
  • We can also pre-configure known URLs to be excluded bu default.
@codecapitano codecapitano added the feature Request a new feature label Apr 10, 2024
@codecapitano codecapitano self-assigned this Apr 10, 2024
@codecapitano
Copy link
Collaborator Author

@codecapitano
Copy link
Collaborator Author

codecapitano commented Apr 17, 2024

Note:
We'll change this from exclude list to allow list

Update:
We'll keep the exclude pattern because the otel instruments used by the web-tracing package only provide ignoreUrls and having allow URLs would add a lot of custom logic.

@codecapitano
Copy link
Collaborator Author

Too ignore endpoints for all URLs but current domain.

const currentDomain = window.location.hostname;

ignoreUrls: [new RegExp(`^(?!.*${currentDomain})`)],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant