-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
553 allow to exclude requests to certain urls from tracking on a global level #554
Merged
codecapitano
merged 18 commits into
main
from
553-allow-to-exclude-requests-to-certain-urls-from-tracking-on-a-global-level
Apr 26, 2024
Merged
553 allow to exclude requests to certain urls from tracking on a global level #554
codecapitano
merged 18 commits into
main
from
553-allow-to-exclude-requests-to-certain-urls-from-tracking-on-a-global-level
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskirk
reviewed
Apr 16, 2024
experimental/instrumentation-performance-timeline/src/instrumentation.test.ts
Outdated
Show resolved
Hide resolved
eskirk
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of good tests, thanks for replacing the ad-hoc type with Patterns
Too ignore endpoints for all URLs but current domain. const currentDomain = window.location.hostname;
ignoreUrls: [new RegExp(`^(?!.*${currentDomain})`)], |
They are received from teh configured transport
codecapitano
force-pushed
the
553-allow-to-exclude-requests-to-certain-urls-from-tracking-on-a-global-level
branch
from
April 26, 2024 10:03
a3a4a37
to
08aba4f
Compare
codecapitano
deleted the
553-allow-to-exclude-requests-to-certain-urls-from-tracking-on-a-global-level
branch
April 26, 2024 10:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Faro does not provide an easy to use option to globally ignore endpoints from being tracked.
This only applies to requests to endpoints, not page URLs of a website.
This helps to reduce noise and save resources (# of requests, amount of data sent) of visitors of the web site and can remove noise from RUM data.
For example tracking the load performance to common analytics libraries all the time may not provide much value.
Currently this affects the following instruments:
What
ignoreEndpoints
property to define strings and regex patterns for URLs to be excludedLinks
Cloud docs, Performance Instrumentation
Checklist