Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

555 only include xhr and fetch performance timings by default more is opt in #560

Conversation

codecapitano
Copy link
Collaborator

@codecapitano codecapitano commented Apr 16, 2024

Why

The Faro performance instrumentation processes and sends all resource entries emitted by the browsers resource timeline.
The number of entries emitted can grow very large depending on how resource heavy a web app/site is.
This can be hundreds of items and more per user session!

Most users are interested in initial load and render performance, web-vitals and xhr/fetch performance.
So we want to decrease resource consumption by only tracking the most necessary entries an make the rest opt-in

What

  • Only track resources initiated by the fetch method or xhml-http-request i. e. initiatorType: xmlhttprequest | fetch
  • Allow to enable tracking all resource entries or to disable tracking of resource items

Links

Checklist

  • Tests added
  • Changelog updated
  • Documentation updated

@codecapitano codecapitano force-pushed the 555-only-include-xhr-and-fetch-performance-timings-by-default-more-is-opt-in branch from 93eb2fc to 740b715 Compare April 16, 2024 14:59
Copy link
Collaborator

@eskirk eskirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - simple and easy to understand, should be very helpful. nice work.

@codecapitano codecapitano merged commit 87cb4a0 into main Apr 16, 2024
2 checks passed
@codecapitano codecapitano deleted the 555-only-include-xhr-and-fetch-performance-timings-by-default-more-is-opt-in branch April 16, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only include XHR and Fetch performance timings by default, more is opt-in.
2 participants