Update demo #563
Merged
Update demo #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the demo by: * fixing the docker images tag for better repeatability * replace Cortex by Mimir * simplify `demo_demo_logs` volume to address grafana#521 Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
|
|
codecapitano
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
LGTM 🦖
@wilfriedroset this is great work and it was long overdue.
I am pretty sure this update makes a lot of people, including myself, very happy.
thank you so much 🙏
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This commit updates the demo by:
demo_demo_logsvolume to address Demo app doesn't work #521What
Links
#521 #523
Checklist