Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent/alloy): migrate from Grafana agent to Grafana Alloy #565

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

bubu11e
Copy link
Contributor

@bubu11e bubu11e commented Apr 23, 2024

Migrate from Grafana agent to Grafana Alloy

Why

Grafana agent has been deprecated in favor of Grafana alloy.

What

Replace Grafana agent by Grafana Alloy

Links

Checklist

  • Changelog updated
  • Documentation updated

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Julien Girard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bubu11e bubu11e force-pushed the migrate_agent_to_alloy branch 5 times, most recently from c46e3bd to 2f3eed0 Compare April 23, 2024 14:45
Copy link
Collaborator

@codecapitano codecapitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bubu11e great contribution thank you so much for this 🥳

Just some minor things just to have some stricter defaults for users just copying the code. 🙏

docs/sources/tutorials/quick-start-browser.md Outdated Show resolved Hide resolved
docs/sources/tutorials/quick-start-browser.md Outdated Show resolved Hide resolved
infra/alloy/config/config.alloy Outdated Show resolved Hide resolved
infra/alloy/config/config.alloy Show resolved Hide resolved
infra/alloy/config/config.alloy Show resolved Hide resolved
@bubu11e bubu11e force-pushed the migrate_agent_to_alloy branch 5 times, most recently from c8d1833 to 8ee822e Compare April 26, 2024 10:13
@codecapitano
Copy link
Collaborator

codecapitano commented Apr 26, 2024

@bubu11e I see there are some linter issues which are a bit hard to find sometimes.
If it is fine for you I can fix them for you.

Just give me a 👍 / 👎

@codecapitano
Copy link
Collaborator

@bubu11e I see there are some linter issues which are a bit hard to find sometimes. If it is fine for you I can fix them for you.

Just give me a 👍 / 👎

All right @bubu11e linter issue is fixed 👍

@bubu11e bubu11e force-pushed the migrate_agent_to_alloy branch 2 times, most recently from c4e67f3 to 5645a40 Compare April 26, 2024 13:05
@bubu11e
Copy link
Contributor Author

bubu11e commented Apr 26, 2024

@bubu11e I see there are some linter issues which are a bit hard to find sometimes. If it is fine for you I can fix them for you.
Just give me a 👍 / 👎

All right @bubu11e linter issue is fixed 👍

Thanks a lot.

Copy link
Collaborator

@codecapitano codecapitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution.
This was quite often requested since alloy was released.

Thank you so much 🙏 🥳

@codecapitano codecapitano merged commit 05af2b5 into grafana:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants