-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LogArgsSerializer to customize how args are converter to string #580
Conversation
|
Hi @mxab can you also add the new property to the core readme please. Section: Besides the mandatory properties, Faro configuration also supports the following optional properties: |
Done, do you want me to squash the changes? |
Hey Max you don't need to squash them yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mxab Great addition thank you so much. 🙏
Thanks for opening the initial issue and implementing the solution as well 🥳
yeah I only executed the linter in the core package. thx |
at last the linter approves 😅 |
Why
The default behaviour in
pushLogs
stringifies all arguments in a very simple way. This results in potential[object Object]
log messages if some one or some third party library decides to put complex logs arguments e.g.console.info({foo: "bar"})
What
This PR extends the faro config with a
logArgsSerializer
paremeter that allows to override the default behaviour and put in a custom args rendererfixes #564
Checklist