Update types to work with v6 data routers #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricziel
approved these changes
May 6, 2024
domasx2
approved these changes
May 6, 2024
| caseSensitive?: boolean; | ||
| children?: undefined; | ||
| element?: React.ReactNode | null; | ||
| index?: true; |
There was a problem hiding this comment.
I think index shouldn't be optional here?
There was a problem hiding this comment.
Good catch thank you 🙏
codecapitano
force-pushed
the
582-add-support-for-new-versions-of-react-router-dom
branch
from
a79ce1f
to
44ec391
Compare
codecapitano
deleted the
582-add-support-for-new-versions-of-react-router-dom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There was type issue with newest react (data) router.
Add specific types for
IndexandNonIndexroutes.We took the necessary properties from the
RouteObjecttype as defined by the remix/react router.What
Update types in
withFaroRouterInstrumentationto satisfy the React RouterRouteObjecttype.Links
Screenshots
Before
After
Checklist