Publish helm chart using GH pages #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
|
|
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
Add support for initContainer
|
|
||
| ## InitContainers allows injecting additional initContainers. This is meant to allow doing some changes | ||
| ## (permissions, dir tree) on mounted volumes before starting prometheus |
Comment on lines
+14
to
+22
| icon: https://avatars.githubusercontent.com/u/88781313?s=200&v=4 | ||
| maintainers: | ||
| - name: funkypenguin | ||
| email: davidy@funkypenguin.co.nz | ||
| annotations: | ||
| artifacthub.io/changes: |- | ||
| - kind: added | ||
| description: Initial release |
There was a problem hiding this comment.
Did you copy that over from another repo? The home and icon are wrong. I think having your name as maintainer is misleading as well since you do not have repo access
| volumes: | ||
| {{- toYaml .Values.volumes | nindent 8 }} | ||
| initContainers: | ||
| {{ toYaml .Values.extraInitContainers | indent 8 }} |
There was a problem hiding this comment.
Indent seems wrong. Would look nicer with nindent like the other attributes. Also the value name is not extraInitContainers
Suggested change
| {{ toYaml .Values.extraInitContainers | indent 8 }} | |
| {{- toYaml .Values.initContainers | nindent 8 }} |
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
|
Oh and I got mixed up with the two PRs being open. The initContainers feature shouldn't be here, I think it got added from the other PR/branch by mistake. If you were thinking of bundling the two PRs, I'd rather have two well defined PRs |
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
Fix bad variable name
|
Oops, you're right, the initContainers shouldn't be here. I'll close this PR and open a clean one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys!
Here's a PR to add some GitHub Actions to auto-publish the helm chart, using GitHub Pages. This means that people who use the chart in CI/CD, for example, and who can't do an install directly from helm, can still install a specific version from a URL (in this case, the chart repo would be https://grafana.github.io/flagger-k6-webhook/)
You can test it against the version I published in my fork, at https://funkypenguin.github.io/flagger-k6-webhook/ ;)
D