This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
wip: try to make ds plugin #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#5 ugh go modules
also missed del files from last commit
|
Grafana poc branch will run this now after a build if the plugin.json is changed to datasource. But currently But logs indicate the plugin is running, and not crashing or giving a 'netrpc' error anymore due to mismatch of grpc / plugin / protobuf libs. |
* master: fix tests DataFrameHelper to MutableDataFrame
Closed
|
Fixed the plugin.json files, no need to edit type anymore. |
|
@kylebrandt -- I also updated the circle task and Makefile so it will be in sync (or close anyway!) with grafana/grafana#19029 |
makes slow since it forces rebuild on all packages
currently excluding go.mod/go.sum changes
|
Oops, last commit included mod files that have my paths in them, will fix when I have revisions to point go.mod at. |
need to eliminate simplejson to drop grafana dep
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go mod vendor works now - FML.
Plugin is attempted to be run by Grafana if type is changed to datasource from app. Process dies because it trys to speak netrpc... maybe old version of grpc being vendored with more go mod pain?