This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
chore: remove simplejson dep #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papagian
reviewed
Sep 19, 2019
pkg/gelpoc/nodes.go
Outdated
| query: rn.Query, | ||
| timeRange: tr, | ||
| intervalMS: 1000, | ||
| maxDP: 5000, |
There was a problem hiding this comment.
intervalMS and maxDP could be constants?
papagian
reviewed
Sep 19, 2019
| if !ok { | ||
| return nil, fmt.Errorf("expected datasourceId to be a float64, got %T for refId %v", rawDsID, rn.RefID) | ||
| } | ||
| dsNode.datasourceID = int64(floatDsID) |
There was a problem hiding this comment.
Why datasourceId should be float64 in the first place?
There was a problem hiding this comment.
Since the json is decoded into map[string]interface{} all the numbers become floats. Could use https://golang.org/pkg/encoding/json/#Decoder.UseNumber to make it a json.Number but I don't think it really matters in these cases.
papagian
reviewed
Sep 19, 2019
| if !ok { | ||
| return nil, fmt.Errorf("expected orgId to be a float64, got %T for refId %v", rawOrgID, rn.RefID) | ||
| } | ||
| dsNode.orgID = int64(floatOrgID) |
There was a problem hiding this comment.
Same here, why orgId should be float64 in the first place?
papagian
reviewed
Sep 19, 2019
| if floatMaxDP, ok = rawMaxDP.(float64); !ok { | ||
| return nil, fmt.Errorf("expected maxDataPoints to be an float64, got %T for refId %v", rawMaxDP, rn.RefID) | ||
| } | ||
| dsNode.maxDP = int64(floatMaxDP) |
There was a problem hiding this comment.
Same here, why intervalMs and maxDataPoints should be float64 in the first place?
papagian
approved these changes
Sep 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes
grafana/grafanadependency.