This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
WIP: Series Resampling #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resample: add test (currently panics)
papagian
reviewed
Sep 27, 2019
| }, tp{ | ||
| unixTimePointer(10, 0), float64Pointer(1.5), | ||
| }, tp{ | ||
| unixTimePointer(15, 0), float64Pointer(2), |
There was a problem hiding this comment.
Here the value is 2 because the last seen value from the original series is in the 9th second
but I'm not whether we should keep it like this or it should be 1.5 instead (the last value of the resampled series).
There was a problem hiding this comment.
So when downsampling, in order to create a regular series there may be gaps because there was no data in the window to aggregate.
For the first pass I think these can be timestamp,null for now. But eventually we will want some "fill" options for how this is handled. If we were to create an irregular series, then we would omit the point entirely.
kylebrandt
commented
Sep 27, 2019
kylebrandt
commented
Sep 27, 2019
kylebrandt
commented
Sep 27, 2019
kylebrandt
commented
Sep 27, 2019
* Move resample code to separate file. * Declare a separate function for parsing the rule. * Compile regular expression only once
- Rename "VarToReduce" field of "ResampleCommand" to "VarToResample" - Drop dependency to "gonum.org/v1/gonum/stat" - Add support for min, max, count and sum downsampling function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.