This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
Test back-end with CircleCI #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/circleci-tests
branch
from
c474223
to
6b859af
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
commented
Oct 28, 2019
| working_directory: ~/plugin | ||
| steps: | ||
| - checkout | ||
| - restore_cache: | ||
| keys: | ||
| - yarn-packages-{{ checksum "yarn.lock" }} | ||
| - run: | ||
| name: Install yarn and Go | ||
| name: Install node and yarn |
There was a problem hiding this comment.
AFAICT, the step doesn't install Go.
aknuds1
commented
Oct 28, 2019
| @@ -53,15 +53,15 @@ jobs: | |||
| - ci | |||
| build_backend: | |||
| docker: | |||
| - image: circleci/golang:1.12 | |||
| - image: circleci/golang:1.13 | |||
There was a problem hiding this comment.
I guess it's better to upgrade to latest Go?
aknuds1
commented
Oct 28, 2019
| @@ -65,7 +65,7 @@ func parseRule(rule string) (time.Duration, error) { | |||
| func (s Series) Resample(rule string, downsampler string, upsampler string, tr grafana.TimeRange) (Series, error) { | |||
| interval, err := parseRule(rule) | |||
| if err != nil { | |||
| return s, fmt.Errorf(`failed to parse "rule" field "%v": %v`, rule, err) | |||
| return s, fmt.Errorf(`failed to parse "rule" field %q: %w`, rule, err) | |||
There was a problem hiding this comment.
I think it's better to wrap the originating error than to just include the message.
aknuds1
commented
Oct 28, 2019
| @@ -26,7 +26,7 @@ func TestResampleSeries(t *testing.T) { | |||
| upsampler: "fillna", | |||
| timeRange: grafana.TimeRange{ | |||
| From: time.Unix(0, 0), | |||
| To: time.Unix(11, 0), | |||
| To: time.Unix(4, 0), | |||
There was a problem hiding this comment.
This triggers the error condition the test case is for. I need feedback though from someone with more domain knowledge on whether it's correct or not. @kylebrandt?
There was a problem hiding this comment.
This fix seems correct. I wonder how we hadn't caught this before.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CircleCI configuration to also test back-end. Fixes #2.
I had to modify a test case that would fail, could use feedback on whether my change is correct.