This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
Fix series length on binary series op series operations #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
changed the title
binaryOp should really just take pointers, but that can be done later
kylebrandt
previously approved these changes
Nov 4, 2019
There was a problem hiding this comment.
We will need the PR for the SDK as we will want to merge that, and then this referencing master commt on sdk once that is merged. Other than that looks good to me :-) I tested a Panel that used to be showing the "datapoints out of range" due to this issue and that no longer happens.
aknuds1
changed the title
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
kylebrandt
approved these changes
Nov 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix binary operations on series x series when they don't have corresponding time points, i.e. make sure the resulting series only has time points found in both inputs.
Fixes #38.