This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kylebrandt
commented
Nov 20, 2019
•
edited
edited
- Depends on dataframe: method to get underlying type of Vector grafana-plugin-sdk-go#24 getting merged at tagged with release.
This reverts commit 4b6738b.
Basic Idea: non-pointer type is a proper subset its pointer type (nullable type), i.e. float64 ⊂ *float64
Is this actually what I did ... |
kylebrandt
commented
Nov 25, 2019
go.mod
Outdated
github.com/google/go-cmp v0.3.1 | ||
github.com/grafana/grafana-plugin-sdk-go v0.2.0 | ||
github.com/grafana/grafana-plugin-sdk-go v0.2.1-0.20191120150621-555ae32d7580 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs sdk pr merged, then this updated
I don't know that it is fair to ask for a review on this ... is quite large, moved some tests around. This tests are still a mess, I need to make a scenario matrix of some sort and figure out how they should be structured. Currently just continuing some debt. I think after Frame.Labels -> Frame.Field.Labels is probably a good time to do that. Main changes are type_series. Some TODOs are left in there but I am okay with that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.