This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
Convert from Make to Mage #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
|
Dooh sorry did not see this PR... either use this or #68 the common stuff expects |
|
@ryantxu I will try to consolidate the two PRs :) |
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
ryantxu
reviewed
Apr 9, 2020
ryantxu
reviewed
Apr 9, 2020
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-Authored-By: Ryan McKinley <ryantxu@gmail.com>
kylebrandt
reviewed
Apr 9, 2020
kylebrandt
reviewed
Apr 9, 2020
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
|
Thanks @kylebrandt :) |
kylebrandt
approved these changes
Apr 9, 2020
|
@kylebrandt Sure, but I'm getting feedback from @ryantxu on this one, so I think we're covered :) |
ryantxu
approved these changes
Apr 9, 2020
|
@ryantxu Yep!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert from Make to Mage. Use SDK's Mage logic.