Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters which are nullable or "possibly undefined" should have a toggle that enables or disables them #11

Closed
kminehart opened this issue Aug 21, 2020 · 0 comments
Assignees

Comments

@kminehart
Copy link
Contributor

Problem: When changing inputs from populated to empty, the query fails to complete.

Reproducing:

Step 1: Search for issues with a valid assignee.

image

Step 2: Removing the content from the "assignee" field should result in an error:

Could not find an assignee with the login ''

This is caused by the behavior of the omitempty flag on the IssueFilters type.

For more information on omitempty: https://golang.org/pkg/encoding/json/


Solution: Filters which are nullable or "possibly undefined" should have a toggle that enables or disables them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants