Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing repositories doesn't find all of them #59

Closed
maximbaz opened this issue Sep 14, 2020 · 1 comment · Fixed by #63
Closed

Listing repositories doesn't find all of them #59

maximbaz opened this issue Sep 14, 2020 · 1 comment · Fixed by #63
Assignees
Labels
type/feature-request Requested new feature or enhancement

Comments

@maximbaz
Copy link

This is a follow-up to #52, I tested creating a dashboard variable for repositories of my team within the organization (using regex /^myteam-.*/), and I noticed that the resulting variable doesn't contain all of our repos.

I think it's simply because our organization has more than 1.5k repos currently, and I presume that the current approach limits the amount of repos it can return.

Let me know if you need some extra info and I will try to collect it for you 🙂

@kminehart
Copy link
Contributor

kminehart commented Sep 14, 2020

That's a lot! Luckily that probably doesn't change very much.

GitHub access tokens have a limit of 5,000 requests per 30 minutes. Everything is listed in pages of 100, so I tried to set a limit on the number of pages pretty low since people will very easily max out their tokens, especially in shared environments.

I can remove the limit on Repositories since they're only used in variables, and maybe increase the cache timeout on Repositories to 30 minutes or so.


I can make this change and release it by the end of the day today.

@kminehart kminehart self-assigned this Sep 14, 2020
@kminehart kminehart added the type/feature-request Requested new feature or enhancement label Sep 14, 2020
@kminehart kminehart added this to the v1.0.4 milestone Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Requested new feature or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants