Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR ID, URL, and Repository to Pull Requests results #60

Closed
maximbaz opened this issue Sep 14, 2020 · 6 comments · Fixed by #63
Closed

Add PR ID, URL, and Repository to Pull Requests results #60

maximbaz opened this issue Sep 14, 2020 · 6 comments · Fixed by #63
Assignees
Labels
type/feature-request Requested new feature or enhancement

Comments

@maximbaz
Copy link

When querying pull requests, I would like to present them in a table and use "data link" to make the PR title a link that on click opens the PR on Github in a new browser tab. In general adding url property would probably be easiest to use, but if you could at least expose the PR id then I would be able to re-construct the full URL myself 🙂

Let me know if this makes sense 🙂

@kminehart
Copy link
Contributor

Easy enough. I'll add both!

@kminehart kminehart self-assigned this Sep 14, 2020
@kminehart kminehart added the type/feature-request Requested new feature or enhancement label Sep 14, 2020
@kminehart kminehart added this to the v1.0.4 milestone Sep 14, 2020
@maximbaz
Copy link
Author

Could you please also add repo name? I want to try merge transformation (where I would hardcode repo names directly in the queries - could later generate the dashboard JSON), and the only thing I would be missing in the merged table is the repo name next to the PR title. Thanks!

@kminehart kminehart changed the title Add PR ID or URL to the results Add PR ID, URL, and Repository to Pull Requests results Sep 14, 2020
@kminehart
Copy link
Contributor

Thanks for your feedback! It is much appreciated.

Just released v1.0.4, take a look when you have a chance.

@maximbaz
Copy link
Author

maximbaz commented Sep 15, 2020

Thanks for your help!

This might be a stupid question, but I don't see the new columns, I double-checked that the datasource version is 1.0.4, but if I just create a brand new dashboard, new table panel, and in query I set "Github stats > Pull_Requests > fill owner > fill repo name > query empty > Time Field None", then I get some lines in the table, but they do not contain the new fields, it's just "title", "state", "author_login" and so forth...

Can you think of what I might be doing wrong?


I realized that another quite useful column in the table would be a boolean "Approved", to know if anyone has approved the PR already (so that the author can potentially merge it) or not (so that the author has still to wait some more). Would that be possible to add?

@kminehart
Copy link
Contributor

kminehart commented Sep 15, 2020

Ohh. I think I know what happened. I'm still getting used to the release process and I think I forgot to include my changes. Give me one minute.

Approved is a good one, I can add that at some point today. 👍

@kminehart
Copy link
Contributor

#70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Requested new feature or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants