extend readme with info about provisioned data source #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoltanbedi
requested changes
Jun 9, 2022
README.md
Outdated
| @@ -47,6 +47,22 @@ Options: | |||
|
|
|||
| To create a new Access Token, navigate to [Personal Access Tokens](https://github.com/settings/tokens) and create a click "Generate new token." | |||
|
|
|||
| ### Data source with provisioning | |||
| [It’s now possible to configure data sources using config files with Grafana’s provisioning system.](https://grafana.com/docs/grafana/latest/datasources/elasticsearch/#configure-the-data-source-with-provisioning) | |||
There was a problem hiding this comment.
Suggested change
| [It’s now possible to configure data sources using config files with Grafana’s provisioning system.](https://grafana.com/docs/grafana/latest/datasources/elasticsearch/#configure-the-data-source-with-provisioning) | |
| It’s possible to configure data sources using config files with [Grafana’s provisioning system].(https://grafana.com/docs/grafana/latest/administration/provisioning/#data-sources) | |
| ```yaml | |
| # config file version | |
| apiVersion: 1 | |
| datasources: | |
| - name: GitHub Repo Insights | |
| type: grafana-github-datasource | |
| jsonData: | |
| owner: "" | |
| repository: "" | |
| secureJsonData: | |
| accessToken: "<github api token>" |
There was a problem hiding this comment.
Can you please include this as well?
There was a problem hiding this comment.
This yaml-part? It's already in there this would double it?
There was a problem hiding this comment.
We usually add provisioning in the format above thats why I thought that it would make sense to include it that way. But I guess people can figure it out from the prom operator yml whats needed.
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
zoltanbedi
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.