Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query for Github Projects #183

Merged
merged 12 commits into from
Oct 20, 2022
Merged

Query for Github Projects #183

merged 12 commits into from
Oct 20, 2022

Conversation

scottlepp
Copy link
Contributor

@scottlepp scottlepp commented Oct 20, 2022 •
edited

  • adds the ability to query github projects by org ( will add by user later )
  • updates to latest sdk
  • latest sdk allowed removal of interfaces we no longer need
  • move query handlers to github package ( updating sdk changes caused a circular dependency )

NOTE - this pr gives a simple projects query, in subsequent pr will add "Project Items" query type, where we can query for items within the project by name. This will allow drilling down from project list into project.

image

@scottlepp scottlepp requested review from a team and yesoreyeram October 20, 2022 16:27
yesoreyeram
yesoreyeram reviewed Oct 20, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
yesoreyeram
yesoreyeram approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@yesoreyeram yesoreyeram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 🚀

src/types.ts Show resolved Hide resolved
@scottlepp scottlepp merged commit 373962b into main Oct 20, 2022
@scottlepp scottlepp deleted the projects branch October 20, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesoreyeram yesoreyeram yesoreyeram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scottlepp @yesoreyeram