Feat: Project items - issues, draft issues, prs in a project #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scottlepp
commented
Nov 2, 2022
scottlepp
commented
ktw4071
approved these changes
Nov 3, 2022
bossinc
reviewed
Nov 3, 2022
yesoreyeram
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Overall LGTM. 🚀
only concerning thing is the infinite for loop in #184 (comment).
|
Does this only works with projects and not with classic projects. Say grafana/55 works where grafana/13 doesn't work also doesn't throw error. |
|
@yesoreyeram this uses the new projects api, not classic Some values are not nullable. In those cases the type is not a pointer. |
yesoreyeram
reviewed
Nov 3, 2022
can this be mentioned somewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.