Add Prometheus metrics and GoKit logs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
tomwilkie
force-pushed
the
metrics-and-logs
branch
from
e8ecada
to
a423ac3
Compare
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
pracucci
reviewed
Jun 5, 2020
| @@ -550,21 +551,21 @@ func (t *tokenAwareHostPolicy) getMetadataForUpdate() *clusterMeta { | |||
|
|
|||
| // resetTokenRing creates a new tokenRing. | |||
| // It must be called with t.mu locked. | |||
| func (m *clusterMeta) resetTokenRing(partitioner string, hosts []*HostInfo) { | |||
| func (m *clusterMeta) resetTokenRing(partitioner string, hosts []*HostInfo) error { | |||
There was a problem hiding this comment.
Now returns an error, but it's never checked in any place where we call resetTokenRing()
There was a problem hiding this comment.
Agree, its tech debt I need to tidy up in a future refactor. Shouldn't affect us.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.