instrumentation: add request duration metric #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>
Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>
ashwanthgoli
force-pushed
the
add-instrumentation
branch
from
b54a3c9
to
44fa0bc
Compare
5 tasks
56quarters
added a commit
that referenced
this pull request
Sep 13, 2023
The instrumentation adds a dependency on the Prometheus client and didn't end up being used by Loki (or any other database). Removing so this client can be used with only the standard library. Related #12 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
that referenced
this pull request
Sep 14, 2023
The instrumentation adds a dependency on the Prometheus client and didn't end up being used by Loki (or any other database). Removing so this client can be used with only the standard library. Related #12 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
gomemcache_request_duration_secondsto track the time spent in performing cache operations.It's partitioned by the server
addrto enable visibility at per-server level