Rename module to github.com/grafana/gomemcache #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bboreham could you please take a look? I couldn't add reviewers, that's why mentioned you :) |
|
On a point of detail, my upstream PR was reviewed in October this year. |
|
Should we consider starting a fresh repository for this? Otherwise all the PRs will still be sent to bradfitz/gomemcache (because it's a fork) and that would be an eternal mess. |
|
I don't follow "all the PRs will still be sent to bradfitz/gomemcache", considering we are discussing the 6th PR sent to this repo. |
|
I meant that when a repo is a fork, the default behavior of Github's UI is to open PRs on the original repo. |
colega
added a commit
that referenced
this pull request
Dec 15, 2022
Followup on #6 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
bboreham
pushed a commit
that referenced
this pull request
Dec 15, 2022
Followup on #6 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream repo github.com/bradfitz/gomemcache looks stale, the last commit was made 1.5 months ago, and commit before the last one was made almost 1 year ago. Open PRs are waiting for review for a long time.
I suggest moving to grafana fork as a main dependency in repos where this dependency is used to get rid of replacement directives.
For example loki: https://github.com/grafana/loki/blob/9d5665e34aba3fb01cd17aa5c16c562af0ea8a06/go.mod#L324. This replacement is there for more than 2 years