Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using 'grafana_dashboards_dir' not working anymore #85

Closed
cbreit opened this issue Aug 12, 2023 · 0 comments · Fixed by #91
Closed

Using 'grafana_dashboards_dir' not working anymore #85

cbreit opened this issue Aug 12, 2023 · 0 comments · Fixed by #91
Assignees

Comments

@cbreit
Copy link

cbreit commented Aug 12, 2023

When using grafana_dashboards_dir, the following error occurs:

TASK [grafana.grafana.grafana : Import grafana dashboards] 
fatal: [****]: FAILED! => {"msg": "'dict object' has no attribute 'path'. 'dict object' has no attribute 'path'"}

The reason is that __tmp_dashboards is not defined anymore.

The 'when' statement was around the "Download grafana dashboard...' step initially:
https://github.com/cloudalchemy/ansible-grafana/blob/b77b25607003c4cd9fd03091d03119d1dc8c2700/tasks/dashboards.yml#L27

But now you have moved it so that it covers the whole block, what destroys the functionality of "grafana_dashboards_dir" and makes predefined dashboards unusable.

when: "grafana_dashboards | length > 0"

Please fix the issue and move the 'when' back where it was :-)
Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants