Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Support UID for playlists #100

Merged
merged 4 commits into from
Jul 15, 2022
Merged

Conversation

julienduchesne
Copy link
Member

This is how Grafana 9.0 manages playlists now
This is done in a way that's retrocompatible with Grafana 8 though (id or UID accepted in functions)

Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but given that the changes for *Client.Playlist, *Client.NewPlaylist, and *Client.UpdatePlaylist are all breaking changes (we're changing a public API), we probably should increment the major version when releasing this.

@julienduchesne
Copy link
Member Author

Changes LGTM, but given that the changes for *Client.Playlist, *Client.NewPlaylist, and *Client.UpdatePlaylist are all breaking changes (we're changing a public API), we probably should increment the major version when releasing this.

Major is zero. According to semver, I can break the API on a minor 😄

@julienduchesne julienduchesne merged commit 4b8162b into master Jul 15, 2022
@julienduchesne julienduchesne deleted the julienduchesne/playlist-uid branch July 15, 2022 00:52
@inkel
Copy link
Contributor

inkel commented Jul 15, 2022

Hah! Good point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants