This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Alerting: Convenience translations for For field in alert rules #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnnyQQQQ
approved these changes
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
forfield in rules was broken for a while and was recently fixed in 9.1. This client also provided the value in the wrong format, using a raw serializedtime.Durationrather than the string-based format that Prometheus expects.This PR adds a new string field called
Forto the alert rule model, which takes the prom-style format.We also add some convenience translations: whether the user wishes to provide a
time.Durationor the prom-style duration, we now accept both and send the right thing regardless. The result is that this change is completely backwards-compatible, and improves the usability of the client by supporting whatever type the caller prefers.