This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Add an integration testing pattern and a few team integration tests #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Mike Ball <mikedball@gmail.com>
mdb
commented
Aug 14, 2022
| grafana: | ||
| image: grafana/grafana:${GRAFANA_VERSION} | ||
| networks: | ||
| - grafana-api-golang-client-test |
There was a problem hiding this comment.
This is very similar to terraform-provider-grafana's docker-compose.yml.
mdb
commented
Aug 14, 2022
| if err != nil { | ||
| t.Fatalf("failed to delete team: %v", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
There may be more elegant ways to organize these tests, but I chose to err on the side of simplicity, at least for now.
Signed-off-by: Mike Ball <mikedball@gmail.com>
|
👋 I am closing this PR because this repository is now deprecated and will be archived. It will still be accessible in read-only mode. We are now generating the Grafana client from its OpenAPI spec. Check out https://github.com/grafana/grafana-openapi-client-go for the new client. Consider opening an issue or a PR there if functionality is missing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
grafana-api-golang-clientcan be integration tested using a local, Dockerized Grafana instanceFurther context:
Without a suite of easy-to-run integration tests,
grafana-api-golang-clientfunctionality and bugs were a bit difficult to prove and discuss. In particular, this PR seeks to offer a simple testing technique to assist PR 102 discussion.Potential further follow-on improvements: