Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Removed deprecated prop AzureLogAnalyticsSameAs #106

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

yaelleC
Copy link
Contributor

@yaelleC yaelleC commented Aug 22, 2022

Following this escalation : https://github.com/grafana/support-escalations/issues/3560

Terraform is setting a deprecated bool to false when creating an Azure Monitor data source, this PR removes the deprecated prop.

Note to Reviewer
Happy for you to weigh in if you think that this fix is not right for the escalation above,
I have very limited terraform context 馃槂

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2022

CLA assistant check
All committers have signed the CLA.

@yaelleC yaelleC requested a review from inkel August 22, 2022 10:03
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. Grafana 8.1 is old at this point and we can't support different sets of attributes for different versions

@julienduchesne julienduchesne merged commit d77b82f into master Aug 22, 2022
@julienduchesne julienduchesne deleted the yaelleC-fix-escalation-3560 branch August 22, 2022 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants