This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Allow setting status codes to retry #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For grafana/terraform-provider-grafana#893 We currently retry 429 and 5xx. This is retained as a default in this PR but there's a new `RetryStatusCodes` that, if set, overrides these statuses That way, the user that opened the issue above will be able to also retry 407 on their Azure instance **Had to do some fixes in dashboard tests, the httptest servers were not properly used, not closed and leaked out of the tests**
inkel
approved these changes
Jun 6, 2023
Perhaps these should have been done in a previous PR? 🤔 |
Hard to reproduce the bug in another PR because they didn't fail until you added a new test that used a httptest server. Probably because of test ordering |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For grafana/terraform-provider-grafana#893
We currently retry 429 and 5xx. This is retained as a default in this PR but there's a new
RetryStatusCodesthat, if set, overrides these statusesThat way, the user that opened the issue above will be able to also retry 407 on their Azure instance
Had to do some fixes in dashboard tests, the httptest servers were not properly used, not closed and leaked out of the tests