Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

fix connection leak #162

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix connection leak #162

merged 3 commits into from
Oct 5, 2023

Conversation

hoozecn
Copy link
Contributor

@hoozecn hoozecn commented Sep 11, 2023

We got a lot of established connections(over 20,000) when using grafana-operator depends on this library and the leak made the operator couldn't visit grafana anymore.

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2023

CLA assistant check
All committers have signed the CLA.

@hoozecn
Copy link
Contributor Author

hoozecn commented Sep 11, 2023

/assign @julienduchesne

Copy link
Contributor

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it look good enough to be merged to you? cc/ @inkel Thanks!

Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Left a minor suggestion but LGTM.

client.go Outdated Show resolved Hide resolved
@joanlopez joanlopez merged commit 93559f4 into grafana:master Oct 5, 2023
2 checks passed
@hoozecn hoozecn deleted the fix-resp-body-leak branch October 7, 2023 01:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants