Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Updates SLO types #168

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Updates SLO types #168

merged 4 commits into from
Oct 31, 2023

Conversation

elainevuong
Copy link
Contributor

@elainevuong elainevuong commented Oct 30, 2023

Updates SLO Types in GAPI to prepare for changes to the Grafana Terraform Provider to support the Destination Datasource field on the SLO

Note: The tests within GAPI fail if I used Uid or Uuid - so I had to change all the type fields to be UUID / UID respectively.

Copy link

@ellisda ellisda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I did have some comments/questions, but they're minor and you can feel free to disagree

slo.go Outdated Show resolved Hide resolved
slo.go Outdated Show resolved Hide resolved
slo.go Show resolved Hide resolved
slo.go Outdated Show resolved Hide resolved
@elainevuong elainevuong merged commit 6d42666 into master Oct 31, 2023
2 checks passed
@elainevuong elainevuong deleted the ev/slo-updates branch October 31, 2023 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants