This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Add omitempty to Preferences theme #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@inkel, could you review it, please? Thanks! LMK if I should ask someone else. |
|
@jaehnri I've rebased the branch with latest |
Signed-off-by: João Henri <joao.henri@suse.com>
|
@inkel, it should be properly rebased now. |
|
Thank you for your contribution! |
|
Hi, @inkel! I hope you're doing well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the
themeattribute fromPreferencesdoes not haveomitempty. That way, whenever it gets marshaled to JSON, the JSON body receives a"theme": "".This makes it impossible to use the Grafana Preferences PATCH endpoint without specifying/updating
themebecause Grafana validates if the given theme is valid, as it is not null:https://github.com/grafana/grafana/blob/1d38edc483570e4767a6ef1800dfdc1b576838c1/pkg/api/preferences.go#L124-L127