Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Datasources: Add xpack option #81

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

julienduchesne
Copy link
Member

Also remove omitempty all boolean attributes of json_data.
For booleans, it's annoying because it makes false values not show up, meaning that once enabled, an attribute can't be disabled
It's fine to always send values for datasources, it just ignores the extra attributes for a datasource

grafana/terraform-provider-grafana#300

Also remove `omitempty` all boolean attributes of json_data.
For booleans, it's annoying because it makes `false` values not show up, meaning that once enabled, an attribute can't be disabled
It's fine to always send values for datasources, it just ignores the extra attributes for a datasource

grafana/terraform-provider-grafana#300
@julienduchesne julienduchesne requested a review from a team May 26, 2022 19:40
Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 thanks!

@julienduchesne julienduchesne merged commit a550de4 into master May 26, 2022
@julienduchesne julienduchesne deleted the julienduchesne/xpack branch May 26, 2022 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants