This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Alerting: Add support for Unified Alerting contact points, deprecate legacy notifiers #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
force-pushed
the
alexweav/alerting-contact-points
branch
from
76cd8b4
to
3763061
Compare
|
Nice, that's a bug in the linter. Turns out the following deprecation comment fails the lint: The linter is seeing a sentence containing the words "deprecated in" and suggesting to make that sentence a properly formatted deprecation comment. But, it doesn't think to check whether the sentence is already a deprecation comment to begin with. https://github.com/go-critic/go-critic/blob/bf8c01ca6692a5a3e8c20b1caef47dfab1412c88/checkers/deprecatedComment_checker.go#L119 |
|
|
julienduchesne
approved these changes
Jun 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Unified Alerting's
ContactPointobject. The Grafana Terraform provider will consume these new APIs in a future PR.This client also exposes functionality for manipulating legacy alerting "notifiers." Notifiers are legacy alerting's equivalent of contact points.
Legacy alerting as a whole was deprecated in the Grafana project as of 9.0. So, this PR marks the old notifier endpoints as deprecated in favor of contact points.