Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Alerting: Add method for fetching an entire rule group #96

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

alexweav
Copy link
Contributor

@alexweav alexweav commented Jul 7, 2022

Adds a method wrapping a new Alerting endpoint which can fetch an entire rule group at once. This supplements the existing method to fetch just a single rule at a time.

Copy link

@santihernandezc santihernandezc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, I think we could improve the test logs.

alerting_alert_rule_test.go Outdated Show resolved Hide resolved
alerting_alert_rule_test.go Outdated Show resolved Hide resolved
alerting_alert_rule_test.go Outdated Show resolved Hide resolved
alerting_alert_rule_test.go Show resolved Hide resolved
Copy link

@santihernandezc santihernandezc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
2 participants