Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Alerting: Add method for querying contact points by name #97

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

alexweav
Copy link
Contributor

@alexweav alexweav commented Jul 7, 2022

This PR adds a method for getting contact points with a given name. This supplements the current method which gets all contact points.

@alexweav alexweav changed the title Alerting; Add method for querying contact points by name Alerting: Add method for querying contact points by name Jul 7, 2022
Copy link

@santihernandezc santihernandezc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added some comments in the test file.
Is there any reason for logging the entire object when an assertion fails?

alerting_contact_point_test.go Outdated Show resolved Hide resolved
alerting_contact_point_test.go Outdated Show resolved Hide resolved
@alexweav alexweav merged commit a07c689 into master Jul 12, 2022
@alexweav alexweav deleted the alexweav/contact-points-by-name branch July 12, 2022 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
2 participants