Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yarn dev script #13

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Fix yarn dev script #13

merged 1 commit into from
Mar 20, 2023

Conversation

kevinwcyu
Copy link
Collaborator

  • add --watch flag for rollup
  • add --watch.onStart=\"yarn typecheck\" to ensure ./compiled types are available when running yarn dev. Previously a clean repo would throw an error unless yarn typecheck was not run before yarn dev

@kevinwcyu kevinwcyu requested a review from a team as a code owner March 17, 2023 16:43
@kevinwcyu kevinwcyu requested review from sarahzinger and idastambuk and removed request for a team March 17, 2023 16:43
@kevinwcyu kevinwcyu merged commit 94b40b8 into main Mar 20, 2023
@kevinwcyu kevinwcyu deleted the kevinwcyu/fix-npm-scripts branch March 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwysiu iwysiu iwysiu approved these changes

@idastambuk idastambuk idastambuk approved these changes

@sarahzinger sarahzinger Awaiting requested review from sarahzinger sarahzinger is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinwcyu @iwysiu @idastambuk