Add CODEOWNERS #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
requested review from
a team,
iwysiu and
idastambuk
and removed request for
a team
vickyyyyyyy
reviewed
Jan 3, 2023
.github/CODEOWNERS
Outdated
|
|
||
| # This should make it easy to add new rules without breaking existing ones. | ||
|
|
||
| - @grafana/aws-plugins |
There was a problem hiding this comment.
I haven't seen the - syntax in our files before, does it work the same way as the * we use in other repos? https://github.com/grafana/athena-datasource/blob/main/.github/CODEOWNERS
There was a problem hiding this comment.
good catch. one of my vscode extensions auto-formats this as a markdown file on save. didn't notice it was doing this cause i just copied the codeowners file from another repo.
iwysiu
approved these changes
Jan 4, 2023
sarahzinger
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.