Update configs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
force-pushed
the
kevinwcyu/update-configs
branch
2 times, most recently
from
083c4d7
to
f98cc6d
Compare
kevinwcyu
requested review from
a team,
iwysiu and
idastambuk
and removed request for
a team
kevinwcyu
force-pushed
the
kevinwcyu/update-configs
branch
from
f98cc6d
to
caa3ec6
Compare
kevinwcyu
force-pushed
the
kevinwcyu/update-configs
branch
from
caa3ec6
to
4f2dfe6
Compare
iwysiu
approved these changes
Jan 4, 2023
sarahzinger
approved these changes
Jan 4, 2023
| @@ -1,3 +1,10 @@ | |||
| module.exports = { | |||
| ...require('@grafana/toolkit/src/config/prettier.plugin.config.json'), | |||
There was a problem hiding this comment.
what do you think of having a .config folder and extending that rather than copying over the contents of the config folder into our config pages. That way its a bit more obvious what pieces we are directly extending in this repo and what pieces are coming from some sort of default configuration setting? Also if there ever is a way to like migrate to new configuration settings maybe it'll be easier?
kevinwcyu
force-pushed
the
kevinwcyu/update-configs
branch
from
4f2dfe6
to
5d0fed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates configuration for
Removes
@grafana/tookitThe configuration updates made match what is used scaffolded by the create-plugin tool. The only difference is I added the configuration files to the root directory instead of a separate
.configdir (for an example of this see how the configuration is setup in redshift-datasource.Dependencies were also updated in order to support the updated configurations.