Remove backend code #1
Conversation
andresmgot
requested review from
sunker,
a team and
sarahzinger
and removed request for
a team
.eslintrc
Outdated
| "no-only-tests/no-only-tests": "error", | ||
| "react/prop-types": "off", | ||
| "@emotion/jsx-import": "error", | ||
| "lodash/import-scope": [2, "member"] |
There was a problem hiding this comment.
just curious what inspired the need to extend what we have? Seems like we'd want to keep things more or less in line with whatever the defaults right?
There was a problem hiding this comment.
I just copied this from the root of grafana/grafana but I guess it's not really that needed. I can just use the default.
| @@ -32,7 +32,7 @@ func Drone() error { | |||
| return err | |||
| } | |||
|
|
|||
| if err := sh.RunV("drone", "--server", "https://drone.grafana.net", "sign", "--save", "grafana/grafana-plugin-sdk-go"); err != nil { | |||
| if err := sh.RunV("drone", "--server", "https://drone.grafana.net", "sign", "--save", "grafana/grafana-aws-sdk-react"); err != nil { | |||
There was a problem hiding this comment.
Do we need to have this file for Drone?
There was a problem hiding this comment.
Not really, it was just out of convenience to not having to remember the whole drone command but I can just add it to the docs.
Thanks for the pointer! Yes, I was thinking on adding that when releasing but I can add it to this PR. |
Leave this repository as frontend only.
Issue: grafana/grafana-aws-sdk#26