SQL/ResourceSelector: Allow to set resources #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
requested review from
a team,
fridgepoet,
iwysiu,
yaelleC and
sarahzinger
and removed request for
a team
yaelleC
approved these changes
Feb 21, 2022
| import { render, screen } from '@testing-library/react'; | ||
| import { ResourceSelector, ResourceSelectorProps } from './ResourceSelector'; | ||
| import React from 'react'; |
There was a problem hiding this comment.
I'm used to having React as first, any reason why you moved it?
There was a problem hiding this comment.
I'm now using Typescript Hero to automatically add, order and remove imports. Since it's automatic, it uses the import path to order them (alphabetically). It also differentiate between packages and relative imports.
There was a problem hiding this comment.
I see!
I would have thought it would put default before named imports, but I don't see anything in the eslint or prettier config for it so good to go 👍
| import { SelectableValue } from '@grafana/data'; | ||
| import { InlineField, Select } from '@grafana/ui'; | ||
| import { isEqual } from 'lodash'; | ||
| import React, { useEffect, useMemo, useState } from 'react'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case now that I need to get the list of resources in the parent component so to avoid duplicity, I made it optional to fetch resources in this component.