Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up: Fixed unit test warnings #14

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Clean up: Fixed unit test warnings #14

merged 1 commit into from
Mar 9, 2022

Conversation

yaelleC
Copy link
Contributor

@yaelleC yaelleC commented Mar 8, 2022

When running the tests we had a few warnings :

[Deprecation warning] SelectBase: menuShouldPortal={false} is deprecated. Use menuShouldPortal={true} instead

This PR fixes these warnings 馃檪 using recommendations here: grafana/grafana#42359 (comment)

andresmgot
andresmgot approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yaelleC yaelleC merged commit 159cb21 into main Mar 9, 2022
@yaelleC yaelleC deleted the yaelle/fix-test-warnings branch March 9, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

@sunker sunker Awaiting requested review from sunker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yaelleC @andresmgot