Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release v0.0.36 #19

Merged
merged 1 commit into from
May 19, 2022
Merged

Create release v0.0.36 #19

merged 1 commit into from
May 19, 2022

Conversation

sunker
Copy link
Contributor

@sunker sunker commented May 19, 2022

No description provided.

@sunker sunker requested review from yaelleC and aangelisc May 19, 2022 12:00
@@ -2,6 +2,6 @@

All notable changes to this project will be documented in this file.

## v1.0.0
## v0.0.36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that to follow the same release # as aws-sdk?

Copy link
Contributor Author

@sunker sunker May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing, but this is actually the grafana/aws-sdk. Now this repo contains the code for the npm package, but it used to be part of the https://github.com/grafana/grafana-aws-sdk repo until we decided to separate the frontend from the go code.

The go package versioning does not sync with the npm package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, gotcha thanks!

Copy link
Contributor

@yaelleC yaelleC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Just added a question around the release version number

@sunker sunker marked this pull request as ready for review May 19, 2022 12:43
@sunker sunker merged commit ff52d78 into main May 19, 2022
@sunker sunker deleted the bump-version branch May 19, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants