Fix issue with config select dependencies #20
Conversation
tsconfig.json
Outdated
| @@ -2,6 +2,7 @@ | |||
| "extends": "@grafana/tsconfig/base.json", | |||
| "include": ["src", "index.js"], | |||
| "compilerOptions": { | |||
| "jsx": "react", | |||
There was a problem hiding this comment.
I'm somewhat unclear on this change tbh, I needed it locally but Idk if that means there's something wrong with my setup?
There was a problem hiding this comment.
if it's not in the @grafana/tsconfig/base.json then it's fine to add this here
There was a problem hiding this comment.
it does seem to be there, so I'm going to say this was something weird with my local set up that now seems to have resolved itself (new computer problems haha)
| @@ -0,0 +1,13 @@ | |||
| # Contributing Docs | |||
|
|
|||
| ## Local Dev | |||
There was a problem hiding this comment.
maybe it's just me but I always forget how to do this so I added it to our docs. Idk if this is really best place for it?
sarahzinger
requested review from
a team,
sunker and
aangelisc
and removed request for
a team
CHANGELOG.md
Outdated
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## next | |||
There was a problem hiding this comment.
you can release 0.0.37 after you merge this
| @@ -0,0 +1,13 @@ | |||
| # Contributing Docs | |||
|
|
|||
| ## Local Dev | |||
tsconfig.json
Outdated
| @@ -2,6 +2,7 @@ | |||
| "extends": "@grafana/tsconfig/base.json", | |||
| "include": ["src", "index.js"], | |||
| "compilerOptions": { | |||
| "jsx": "react", | |||
There was a problem hiding this comment.
if it's not in the @grafana/tsconfig/base.json then it's fine to add this here
Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
Fixes grafana/athena-datasource#144
We were missing the dependencies for access key and secret key which meant when these values updated, other select fields (such as catalog in athena) would not re-fetch as it didn't notice a change.