Update dependencies #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
commented
Oct 28, 2022
| @@ -1,4 +1,4 @@ | |||
| import React, { FC, useEffect, useState } from 'react'; | |||
| import React, { FC, useEffect, useMemo, useState } from 'react'; | |||
There was a problem hiding this comment.
Changes in this file are to fix a lint error
kevinwcyu
commented
Oct 28, 2022
Comment on lines
+44
to
+45
| "@types/react": "17.0.42", | ||
| "@types/react-dom": "17.0.14", |
There was a problem hiding this comment.
Updated to versions used in Grafana.
This fixes an issue with the types for the Input component. Typescript was complaining about the translate prop being required even though it's actually optional.
iwysiu
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was pulled out from a larger PR #21 for the long running queries work. It's only to separate out the changes to make the other PR more easy to review.