-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #32
Conversation
"pretty-format": "25.1.0", | ||
"react": "17.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? react and react-dom used to be in yarn.lock only, which meant any deletion of the file caused scripts to fail, since they wouldn't be installed (they're peerDeps of @grafana/ui, so necessary)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but would prefer someone much stronger in frontend to have a look
Update of dependencies is necessary for this ticket: https://github.com/grafana/cloud-data-sources/issues/79