Make ResourceSelector label prop required #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
requested review from
fridgepoet and
iwysiu
and removed request for
a team
iwysiu
approved these changes
Dec 13, 2022
sunker
approved these changes
Dec 14, 2022
idastambuk
approved these changes
Dec 14, 2022
|
Actually going to close this. The the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
ResourceSelector'slabelprop required.This was split out as a piece of work from https://github.com/grafana/grafana-aws-sdk-react/pull/33/files#r1044841576.
Note these components are only used by Athena, Redshift, and Timestream. But I ran
yarn buildon all of the AWS data sources to check that there are no type errors.